Inline Argument.memcpy_if_needed - #314
Merged
avalentino merged 1 commit intoAug 10, 2026
Merged
Conversation
The code in question raises an error if it cannot generate code for the ufunc wrapper of an ERFA C function. Now that the code has been inlined in a `Function` property the error message can report the name of the ERFA function if the error is triggered.
avalentino
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before dc90192 the
Argument.memcpy_if_neededproperty was needed to avoid code duplication, but now it can be inlined easily. Furthermore, the code in question raises an error if it cannot generate code for the ufunc wrapper of an ERFA C function, but because anArgumentinstance does not know whichFunctionit belongs to the error message could not report the ERFA function's name. This PR moves the code to aFunctionproperty, so making the error message more informative is very simple.There are no changes to the files
erfa_generatorcreates.