Skip to content

fix(v8): handle non-string function names - #229

Merged
ldm0 merged 1 commit into
mainfrom
v8__Function__GetName
Aug 26, 2026
Merged

fix(v8): handle non-string function names#229
ldm0 merged 1 commit into
mainfrom
v8__Function__GetName

Conversation

@ldm0

@ldm0 ldm0 commented Aug 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites.

✅ Deterministic fixture diagnostic is clean.

Common ancestor ddb7a847808f → HEAD 0435fa9fb185; benchmark order: base-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success
Extracted rows / contract 179 / 240 184 / 240 +5 (+2.79%)
Contract fill 74.58% 76.67% +2.09 pp (+2.80%)
Sites with rows 37 / 48 38 / 48 +1 (+2.70%)
Sites meeting row contract 35 / 48 36 / 48 +1 (+2.86%)
Unexpected empty sites 11 10 -1 (-9.09%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 35; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 3 extracted: 37; HTTP error + rows: 1; empty: 6; HTTP error + empty: 1; snapshot error + empty: 3
Observed duration 41.85 s 34.81 s -7.03 s (-16.80%)
Estimated CPU 30.31 s 29.93 s -0.39 s (-1.28%)
Peak PSS 281.07 MiB 292.35 MiB +11.28 MiB (+4.01%)
Peak RSS 283.16 MiB 294.48 MiB +11.32 MiB (+4.00%)
Peak threads 27 27 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 32 / 40 +5
games 37 / 40 37 / 40 0
life 25 / 40 25 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [1.035, 2.536, 3.538, 4.54, 5.541, 6.042, 7.043, 8.045, 9.548, 10.549, 11.551, 12.052, 13.054, 14.055, 15.056, 16.557, 17.559, 18.561, 20.063, 21.064, 22.065, 23.567, 24.567, 25.068, 25.568, 27.07, 28.071, 29.072, 30.575, 31.576, 32.577, 34.079, 35.08, 36.08, 37.582, 38.583, 39.584, 41.086]
    y-axis "CPU percent" 0 --> 200
    line [29.96, 10, 123.73, 85.91, 159.79, 143.7, 123.84, 79.81, 105.81, 57.94, 51.9, 0, 123.87, 2, 2, 19.97, 69.92, 45.89, 23.98, 53.98, 23.96, 113.87, 115.96, 113.91, 121.84, 119.88, 39.94, 111.86, 29.92, 87.94, 8, 116.01, 83.8, 8, 0, 141.89, 19.98, 117.91]
Loading
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.035, 1.035, 2.536, 3.538, 4.54, 5.541, 6.042, 7.043, 8.045, 9.548, 10.549, 11.551, 12.052, 13.054, 14.055, 15.056, 16.557, 17.559, 18.561, 20.063, 21.064, 22.065, 23.567, 24.567, 25.068, 25.568, 27.07, 28.071, 29.072, 30.575, 31.576, 32.577, 34.079, 35.08, 36.08, 37.582, 38.583, 39.584, 41.086, 41.846]
    y-axis "Memory MiB" 0 --> 500
    line [23.25, 121.14, 133.46, 182.33, 197.58, 248, 234.24, 230.5, 224.42, 233.16, 233.49, 243.34, 243.09, 218.66, 198.61, 187.89, 195.16, 188.09, 189.02, 187.45, 198.65, 200.48, 213.31, 251.93, 283.16, 236.34, 228.88, 251.57, 218.8, 199.21, 204.43, 204.98, 267, 212.81, 200.48, 196.94, 213.54, 190.46, 233.63, 0]
    line [21.41, 119.02, 131.34, 180.01, 195.46, 245.89, 232.12, 228.39, 222.31, 231.05, 231.37, 241.23, 240.97, 216.55, 196.49, 185.76, 193.03, 185.96, 186.9, 185.32, 196.37, 198.35, 211.18, 249.81, 281.07, 234.22, 226.75, 249.45, 216.68, 197.09, 202.3, 202.86, 264.88, 210.68, 198.35, 194.81, 211.41, 188.33, 231.51, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.038, 2.039, 2.54, 3.04, 3.541, 4.042, 4.543, 5.044, 6.046, 7.047, 8.047, 9.049, 9.55, 10.55, 11.551, 12.552, 13.553, 14.555, 15.555, 16.557, 17.558, 18.559, 19.561, 20.562, 21.563, 22.565, 23.565, 24.566, 25.567, 26.568, 27.068, 28.07, 29.071, 30.073, 31.074, 32.076, 33.076, 34.077]
    y-axis "CPU percent" 0 --> 200
    line [51.93, 107.87, 111.81, 103.96, 117.74, 179.52, 123.74, 149.74, 109.86, 119.9, 43.94, 93.83, 125.78, 82.03, 77.89, 48.01, 9.98, 37.98, 111.94, 51.92, 113.99, 113.81, 123.9, 45.94, 127.83, 117.82, 20.01, 59.93, 3.99, 9.99, 37.97, 115.8, 99.83, 9.99, 2, 157.71, 63.92, 119.85]
Loading
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.037, 1.038, 2.039, 2.54, 3.04, 3.541, 4.042, 4.543, 5.044, 6.046, 7.047, 8.047, 9.049, 9.55, 10.55, 11.551, 12.552, 13.553, 14.555, 15.555, 16.557, 17.558, 18.559, 19.561, 20.562, 21.563, 22.565, 23.565, 24.566, 25.567, 26.568, 27.068, 28.07, 29.071, 30.073, 31.074, 32.076, 33.076, 34.077, 34.814]
    y-axis "Memory MiB" 0 --> 500
    line [20.93, 120.77, 148.67, 170.19, 178.2, 193.21, 226.8, 250.43, 234.41, 216.29, 234.68, 221.26, 237.97, 236.37, 223.27, 215.86, 187.9, 184.88, 179.82, 213.85, 190.03, 202.16, 247.4, 228.23, 206.33, 262.64, 224.56, 202.43, 194.04, 196.53, 199.18, 207.86, 294.48, 232.68, 197.86, 201.14, 210.43, 208.09, 234.5, 0]
    line [19, 118.62, 146.52, 168.04, 176.27, 191.06, 224.66, 248.27, 232.21, 214.09, 232.48, 219.05, 235.77, 234.17, 221.06, 213.65, 185.58, 182.68, 177.62, 211.68, 187.85, 199.97, 245.19, 225.9, 204.47, 260.45, 222.36, 200.23, 191.85, 194.33, 196.98, 205.65, 292.35, 230.47, 195.66, 198.94, 208.24, 205.89, 232.18, 0]
Loading

Deterministic fixture · diagnostic

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4
Observed duration 19.91 s 19.91 s +0.00 s (0.00%)
Estimated CPU 0.44 s 0.48 s +0.04 s (+9.05%)
Peak PSS 89.29 MiB 84.32 MiB -4.97 MiB (-5.57%)
Peak RSS 91.40 MiB 86.58 MiB -4.82 MiB (-5.27%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

Spider Bench is informational: site failures, missing benchmark reports, failed browser service runs, fixture diagnostics, timing, and performance deltas do not fail the workflow. Build, runner, and artifact infrastructure errors can still fail it.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor d0b3d4ef0a → HEAD ca6930de34; benchmark order: base-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 200 / 200 200 / 200
Failures / recovered 0 / 0 0 / 0
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 249.7 s 299.0 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 297.6 MiB 295.8 MiB -1.8 MiB
Periodic peak PSS 295.2 MiB 293.5 MiB -1.7 MiB
RSS · first 10 avg 205.6 MiB 216.2 MiB +10.6 MiB
RSS · last 10 avg 228.9 MiB 191.5 MiB -37.4 MiB
RSS · last − first window +23.3 MiB -24.7 MiB -48.0 MiB
RSS · warm slope / 100 nav +5.0 MiB -7.1 MiB -12.1 MiB
PSS · first 10 avg 202.9 MiB 213.5 MiB +10.6 MiB
PSS · last 10 avg 226.5 MiB 189.7 MiB -36.8 MiB
PSS · last − first window +23.6 MiB -23.8 MiB -47.4 MiB
PSS · warm slope / 100 nav +5.2 MiB -6.8 MiB -12.0 MiB
Peak file descriptors 56 52 -4
Peak threads 28 28 0

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 227.1 MiB 206.4 MiB 294.9 MiB 224.6 MiB 203.8 MiB 46
51–100 226.3 MiB 215.1 MiB 289.6 MiB 223.7 MiB 212.4 MiB 48
101–150 222.9 MiB 208.0 MiB 248.0 MiB 220.3 MiB 205.6 MiB 43
151–200 222.4 MiB 179.1 MiB 294.8 MiB 220.2 MiB 177.3 MiB 53

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@ldm0
ldm0 force-pushed the v8__Function__GetName branch from 0435fa9 to ca6930d Compare August 26, 2026 17:05
@github-actions

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 179 / 240 rows; 37 / 48 sites produced rows; 11 unexpected empty sites.

✅ Deterministic fixture diagnostic is clean.

Common ancestor d0b3d4ef0a1c → HEAD ca6930de34e8; benchmark order: base-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success
Extracted rows / contract 179 / 240 179 / 240 0 (0.00%)
Contract fill 74.58% 74.58% 0.00 pp (0.00%)
Sites with rows 37 / 48 37 / 48 0 (0.00%)
Sites meeting row contract 35 / 48 35 / 48 0 (0.00%)
Unexpected empty sites 11 11 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 35; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 3 extracted: 36; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; snapshot error + empty: 3
Observed duration 41.52 s 45.34 s +3.81 s (+9.18%)
Estimated CPU 33.58 s 30.61 s -2.98 s (-8.86%)
Peak PSS 285.97 MiB 262.99 MiB -22.97 MiB (-8.03%)
Peak RSS 288.71 MiB 265.52 MiB -23.19 MiB (-8.03%)
Peak threads 27 26 -1 (-3.70%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 37 / 40 37 / 40 0
life 25 / 40 25 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [1.041, 2.043, 2.543, 3.542, 4.543, 6.045, 7.047, 8.049, 9.05, 10.552, 11.554, 12.555, 13.055, 14.057, 15.059, 16.06, 17.563, 18.565, 19.567, 21.069, 22.071, 23.072, 24.074, 25.578, 26.078, 26.579, 27.581, 29.085, 30.087, 31.089, 32.591, 33.591, 34.595, 35.597, 37.098, 38.099, 39.1, 40.601]
    y-axis "CPU percent" 0 --> 200
    line [45.88, 115.84, 124, 72.03, 149.93, 99.87, 137.61, 133.59, 111.86, 77.91, 109.86, 69.93, 0, 11.97, 71.82, 43.97, 59.85, 41.9, 43.93, 129.84, 127.81, 123.68, 121.86, 131.26, 123.85, 77.87, 113.7, 33.94, 79.87, 11.98, 93.85, 81.9, 93.81, 2, 2, 0, 111.8, 112.01]
Loading
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.039, 1.041, 2.043, 2.543, 3.542, 4.543, 6.045, 7.047, 8.049, 9.05, 10.552, 11.554, 12.555, 13.055, 14.057, 15.059, 16.06, 17.563, 18.565, 19.567, 21.069, 22.071, 23.072, 24.074, 25.578, 26.078, 26.579, 27.581, 29.085, 30.087, 31.089, 32.591, 33.591, 34.595, 35.597, 37.098, 38.099, 39.1, 40.601, 41.523]
    y-axis "Memory MiB" 0 --> 500
    line [23.11, 120.36, 163.22, 169.38, 172.99, 212.18, 243.6, 211.41, 237.31, 219.87, 228.41, 226.12, 192.41, 192.41, 183.07, 179.43, 184.32, 177.66, 189.01, 189.75, 206.78, 244.67, 256.24, 225.22, 213.39, 288.71, 264.14, 243.3, 224.45, 225.88, 217.64, 236.67, 226.19, 225.53, 205.38, 189.4, 183.36, 201.48, 237.24, 0]
    line [20.75, 117.54, 160.38, 166.54, 170.22, 209.57, 240.79, 208.6, 235.67, 217.05, 225.58, 223.31, 189.55, 189.53, 180.2, 176.57, 181.43, 174.82, 186.2, 186.88, 203.92, 241.76, 253.48, 222.36, 210.14, 285.97, 261.29, 240.44, 221.58, 222.98, 214.74, 234.68, 223.33, 222.66, 202.62, 186.67, 180.63, 198.75, 235.75, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.036, 1.538, 2.54, 4.044, 5.047, 6.549, 7.549, 9.05, 10.05, 11.552, 12.553, 14.056, 15.058, 16.559, 17.56, 19.063, 20.064, 21.065, 21.566, 23.068, 24.069, 25.571, 26.572, 28.073, 29.074, 30.576, 31.577, 33.078, 34.081, 35.583, 36.584, 37.084, 38.086, 39.087, 40.588, 41.589, 43.09, 44.092]
    y-axis "CPU percent" 0 --> 200
    line [51.93, 121.64, 107.69, 153.02, 145.71, 145.78, 102.02, 107.99, 99.95, 35.98, 107.91, 19.98, 37.97, 71.95, 119.96, 101.84, 45.97, 0, 3.99, 0, 0, 3.99, 6, 0, 0, 101.89, 111.8, 11.99, 67.83, 5.98, 69.92, 129.89, 113.82, 3.99, 54.02, 2, 54, 115.78]
Loading
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.036, 1.036, 1.538, 2.54, 4.044, 5.047, 6.549, 7.549, 9.05, 10.05, 11.552, 12.553, 14.056, 15.058, 16.559, 17.56, 19.063, 20.064, 21.065, 21.566, 23.068, 24.069, 25.571, 26.572, 28.073, 29.074, 30.576, 31.577, 33.078, 34.081, 35.583, 36.584, 37.084, 38.086, 39.087, 40.588, 41.589, 43.09, 44.092, 45.336]
    y-axis "Memory MiB" 0 --> 500
    line [23.15, 122.59, 142.22, 183.77, 230.91, 228.8, 258, 228.72, 247.45, 206.68, 197.82, 200.67, 191.19, 183.07, 200.05, 207.03, 264.26, 204.85, 197.5, 194.59, 193.85, 193.71, 191.96, 191.8, 191.77, 191.84, 190.54, 207.97, 189.73, 198.16, 196.54, 215.24, 265.52, 230.34, 198, 216.24, 194.51, 204.76, 223.39, 0]
    line [20.99, 120.1, 139.73, 181.21, 232.36, 226.27, 255.46, 226.22, 245.18, 204.19, 195.25, 198.18, 188.7, 180.57, 197.52, 204.52, 261.8, 202.34, 194.99, 192.08, 191.34, 191.2, 189.46, 189.27, 189.24, 189.29, 187.98, 204.92, 187.21, 195.63, 194.01, 212.71, 262.99, 227.84, 195.47, 213.71, 191.98, 202.06, 220.87, 0]
Loading

Deterministic fixture · diagnostic

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4
Observed duration 20.26 s 20.09 s -0.17 s (-0.82%)
Estimated CPU 0.47 s 0.44 s -0.03 s (-6.54%)
Peak PSS 83.08 MiB 86.56 MiB +3.48 MiB (+4.19%)
Peak RSS 85.74 MiB 89.19 MiB +3.45 MiB (+4.03%)
Peak threads 19 18 -1 (-5.26%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

Spider Bench is informational: site failures, missing benchmark reports, failed browser service runs, fixture diagnostics, timing, and performance deltas do not fail the workflow. Build, runner, and artifact infrastructure errors can still fail it.

@ldm0
ldm0 merged commit 2bead09 into main Aug 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant