feat: support Linux x64 - #11
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f023da32af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "version": "1.1.15", | ||
| "repository": "https://github.com/lexmount/browser-cli-rs.git", | ||
| "commit": "3af544780365309feae97d51b631070e7ca73762", | ||
| "commit": "952a5e53ff9dd3980342d4dae7f860f80b39a100", |
There was a problem hiding this comment.
Update the CI pin with the native source bump
The Verify native source pin step in .github/workflows/ci.yml still requires version 1.1.13 and commit 3af544780365309feae97d51b631070e7ca73762. With this metadata now declaring 1.1.15 and the new commit, its inline Node command exits with status 1 in every pull-request and main CI matrix job, so this change cannot pass the repository's CI until that workflow assertion is updated.
Useful? React with 👍 / 👎.
|
Addressed the P1 concern in @codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
v1.1.15at commit952a5e53ff9dd3980342d4dae7f860f80b39a100x86_64-unknown-linux-muslasset0.1.0-rc.5Validation
npm run release:check1.1.15doctorsuccessfully (login not configured on this host)dsh web --port 0loaded successfully; test installation was removed afterward