Fix transparent X11 popup window creation - #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transparent X11 popups could fail with
BadMatchduringXCreateWindow: the 32-bit child inherited the root’s border pixmap becauseborder_pixelwas omitted from the attribute mask. Set an explicit zero border pixel, includeCWBorderPixel, and fail clearly when no 32-bit TrueColor visual is available.The popup test now covers both opaque and transparent X11 software popups and is included in the legacy test task, so Linux CI runs it under its depth-24 Xvfb. This also exports the WinAPI base initializer used by the OpenGL and Vulkan window modules after the upstream incremental-compilation import cleanup.
Validation:
atlas-run tests tpopup_api --no-shuffle;atlas-run tests --compile-only --no-shuffle(14/14).Fixes the X11 menu-popup crash reported at https://forum.nim-lang.org/t/14136#85813.