Fix unbounded X11 window size limits - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some x11 desktops this essentially sets the window size to 1x1.
X11 interprets
PMaxSize/PMinSizeas active constraints; unlike other Siwin backends, it does not treat a zero dimension as an unbounded sentinel when the corresponding flag is present.Clear the relevant size-hint flag when either requested dimension is non-positive, while preserving the stored Siwin minimum/maximum value. Positive dimensions still set the flag and native values. This prevents window managers from collapsing a window to its minimum size (and downstream Vulkan swapchains to 1×1) after an unbounded maximum is applied.
Adds deterministic XSizeHints tests covering positive minimum/maximum constraints and clearing each flag for an unbounded dimension.
Addresses elcritch/merenda#31