Fix Cocoa modifier recovery and duplicate control input - #48
Merged
Conversation
elcritch
force-pushed
the
fix/cocoa-stuck-modifiers
branch
from
August 28, 2026 02:38
8320080 to
c59af94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression sequences
When the app became key while Command was held, refreshModifiers restored the generic modifier mask but the pressed-key set remained empty. The following Command release was therefore toggled into the pressed set as a new press, leaving Command stuck for later key events.
Cocoa also routed Control-letter chords through both the key event callback and NSTextInputClient. Terminal consumers therefore received control bytes such as Control-B and Control-F twice.
Verification