Skip to content

fix(doctor): restore eleven-row System Doctor presentation - #279

Closed
levineam wants to merge 5 commits into
mainfrom
SUP-3896/system-doctor-presentation-fix
Closed

fix(doctor): restore eleven-row System Doctor presentation#279
levineam wants to merge 5 commits into
mainfrom
SUP-3896/system-doctor-presentation-fix

Conversation

@levineam

@levineam levineam commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

Corrective follow-up for SUP-3896 after product rejection of PR #277 presentation.

  • Restore the canonical eleven Memory rows by splitting GBrain core and GBrain semantic coverage
  • Render one status icon per core/optional/Memory line with a concise label/explanation
  • Remove PASS/FAIL tokens, repeated state words, the Selected optional components heading, and the redundant READY aggregate line
  • Keep structured reason codes and authoritative report.ok / receipt status in JSON
  • Add focused presentation regression coverage and update CLI smoke expectations
  • Refresh Compound Engineering fixture digest so isolated doctor smoke does not fail closed on a stale pin

Test plan

  • node --test tests/doctor-modules-test.js tests/doctor-checks-test.js (99 pass)
  • node tests/cli-smoke-test.js
  • CI required checks

Related: SUP-3896

Split GBrain into core and semantic coverage, render one status icon per
component without PASS/FAIL or READY aggregate noise, and keep structured
reason codes authoritative in JSON. Refresh the CE fixture digest so
isolated doctor smoke stays green.
…output

Use the cleaned receipt renderer as the sole human doctor transcript.
Drop permission bits from the Compound Engineering fixture tree digest so
macOS and Linux checkouts validate the same shipped pin. Keeps executable
mode checks on the live fixture files.
…smoke

Align the dormant-runtime template doctor assertion with the cleaned
one-icon presentation (no PASS/FAIL tokens).
@levineam

levineam commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

Retrigger CI after presentation fixes (CE digest + runtime-neutral doctor assertions).

@levineam levineam closed this Sep 4, 2026
@levineam levineam reopened this Sep 4, 2026
@levineam

levineam commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

Superseded by merged #280 (af943b7), which landed the compact eleven-row System Doctor presentation on main.

This branch's follow-up CI fixes (CE digest umask stability + runtime-neutral PASS/FAIL assertion updates) are no longer needed for SUP-3896 closeout because main already has the accepted presentation contract.

@levineam levineam closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant