fix(gbrain): constrain imports to configured vault - #192
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vaultDirto prevent accidental or malicious exfiltration into the brain store.Description
resolveSourcePathnow resolves candidate source paths against the configuredvaultDirand rejects paths that escape the vault (rejects..traversal and absolute escapes).resolveRealSourcePathwhich canonicalizes both the vault and the candidate withrealpathSyncto detect and reject symlink escapes, andcreateImportPlanuses this canonical path for subsequent operations.createImportPlannow emits clearer warnings for missing/out-of-vault sources and excludes any items whose normalized or real path is outside the vault.modules/jarvos-gbrain/test/gbrain.test.jsthat assert rejection of../traversal, absolute outside paths, and symlink-based escapes while preserving normal import behavior.Testing
npm test(which executesnode --test test/*.test.js) and all tests passed (36/36).Codex Task