fix(skills): prevent symlinked install targets - #190
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
prepareInstallDirectoryandassertSafeInstallDirectoryinmodules/jarvos-skills/src/index.js.destinationDirwithassertNoSymlinkComponents, and ensure per-skill directories are created and real-checked withprepareSkillDirectoryto enforce containment under the resolved root.fs.copyFileSyncflow withcopySkillFileSyncwhich opens targets withO_NOFOLLOWand usesO_EXCL(unlessforceis set) to avoid races and prevent following target symlinks, and updateinstallSkillsto preflight and reject non-regular or symlinked targets before writing.realpathof the destination for emitted events and add regression tests inmodules/jarvos-skills/test/skills.test.jsthat verify symlinked directories and symlinked target files cannot redirect installation.Testing
npm testinsidemodules/jarvos-skills, and both@jarvos/skillsbundle and projection tests passed.installSkillsrejects them as expected.git diff --checkto ensure no whitespace or diff errors were introduced and found none.Codex Task