fix(coding): validate live PR merge arguments - #185
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gh pr mergeargv from caller-controlledprNumberandmergeMethod, allowing option-looking values such as--adminto be forwarded to the CLI and enabling privileged behavior escalation.ghflags.Description
ALLOWED_MERGE_METHODSand anormalizeMergeMethodhelper that enforces that the merge method is one ofmerge,rebase, orsquash.normalizePullRequestNumberhelper that requires the PR selector be a positive integer and used both normalizers before building theghargument vector inmerge.live PR adapter rejects option injection in merge inputsthat verifies option-looking selectors and unauthorized merge methods are rejected and that the command runner is not invoked for invalid inputs; the changes touchmodules/jarvos-coding/src/adapters/live/pull-request.jsandmodules/jarvos-coding/test/live-adapters.test.js.Testing
node --test modules/jarvos-coding/test/live-adapters.test.jsand the file-level suite passed with17passing tests and0failures.npm testfor the@jarvos/codingmodule and the full module test run passed with125passing tests and0failures.Codex Task