fix(journal): avoid restoring deleted journals from known-good snapshots - #181
Open
levineam wants to merge 1 commit into
Open
fix(journal): avoid restoring deleted journals from known-good snapshots#181levineam wants to merge 1 commit into
levineam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
syncOneDatesohealthBefore.status === 'missing'is no longer eligible to sourcereadKnownGoodContent, keeping known-good recovery limited tostuband catastrophicstalecases (modules/jarvos-secondbrain/packages/jarvos-secondbrain-journal/src/journal-maintenance.js).restoredKnownGoodis false when a file is missing, ensuring private content is not resurrected (modules/jarvos-secondbrain/tests/journal-maintenance.test.js).Testing
node --test --test-name-pattern='does not restore a deleted journal' tests/journal-maintenance.test.js, which passed.npm test; the updated regression passed and the test run completed with 417 tests executed, 414 passing and 3 unrelated existing failures remaining.Codex Task