Fix stale-lock takeover race in file store - #180
Open
levineam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
state.lockbefore validating owner liveness or age, which temporarily removed live locks and allowed other contenders to acquire the canonical path.Description
lockOwnerIsRunning) and age (staleLockMs) before moving the canonicalstate.lockinrecoverStaleLockso live owners are never displaced.fs.linkSync(takeoverPath, lockPath)instead of renaming to avoid overwriting a newly-created canonical lock when restoring from a takeover file.tokenwhen creating the lock and verify that token on release so a releaser only removes the lock if it still owns it (avoid blindrmby path).stale-lock recovery does not move a live lockproving a live lock is not renamed even when its mtime appears stale, while preserving existing race/regression tests.Testing
node --test modules/jarvos-control-plane/test/storage.test.jsand all control-plane storage tests passed (15/15).npm test --prefix modules/jarvos-control-planeand the suite passed mostly (93 passed, 1 unrelated ownership test failed due to the environment running as root which affects an ownership-specific assertion).git diff --check(no issues reported).Codex Task