fix(ci): restore broad secret scanning and include workflow files in secret-scan - #179
Open
levineam wants to merge 1 commit into
Open
fix(ci): restore broad secret scanning and include workflow files in secret-scan#179levineam wants to merge 1 commit into
levineam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.github/workflows/ci.yml, which allowed common names likeCLIENT_SECRET,DISCORD_TOKEN,BOT_TOKEN, andGITHUB_TOKENto evade CI scanning.Description
patternin.github/workflows/ci.ymlto reintroduce genericsecret,token, andbearername detection (including prefixed/suffixed variants) while retaining the high-confidence token prefixes already present.sensitive_extsallowlist and the explicit exclusion of.github/workflows/ci.ymlsogit grepsearches the full tree by default and changed-content scans cover workflow files as well.git diffthroughgrep -E '^\+'and excluding diff metadata lines withgrep -Ev '^\+\+\+'to avoid matching deleted/context lines; results are still filtered byscripts/filter-secret-scan-candidates.sh.scripts/filter-secret-scan-candidates.shto avoid suppressing the scanner's own pattern/definition lines while preserving the safe-GitHub-secrets reference filter by adjusting the safe-reference and scan-definition regexes.Testing
git diff --checkandbash -n scripts/filter-secret-scan-candidates.shwith no syntax errors reported.grep/pipeline withCLIENT_SECRET,DISCORD_TOKEN,BOT_TOKEN, andGITHUB_TOKENthrough the newpatternandscripts/filter-secret-scan-candidates.sh, which produced the four expected literal candidates while filtering the safe GitHub secrets reference.node --test tests/release-please-config-test.jsand observed4/4tests passing.npm testsuite in this environment and saw92/93control-plane tests pass with a single existing environment-sensitive failure (host-service module owned by an untrusted user is rejected regardless of mode) that is unrelated to the scanner changes.Codex Task