refactor(config): bound recipe composition - #30
Draft
leviking98z-rgb wants to merge 2 commits into
Draft
Conversation
2 tasks
leviking98z-rgb
force-pushed
the
refactor/bounded-recipe-composition
branch
from
August 2, 2026 17:28
56c9bf7 to
86d9673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/_base/; all 120 existing--config-nameentry paths remain unchanged._self_; bases cannot inherit.This reduces recipe YAML from 22,813 to 15,129 lines. Including the guard and documentation, the PR is 2,413 insertions and 9,942 deletions (net -7,529 lines).
This is stacked on
refactor/diffusion-runner(#29 in this fork), not onmain.Related Issue
N/A
Test Plan
pre-commit run --all-files— passed, including all architecture/framework/experimental guards, target resolution, YAML validation, and the new 120-entry composition guard.python -m compileall -q lint unirl— passed.python lint/check_recipe_targets.py— 1,154 recipe_target_paths resolve.python lint/check_architecture_boundaries.py— 475 files / 4,273 internal import edges satisfy all eight boundaries.python lint/check_framework_contracts.py— passed.OmegaConf.to_container(..., resolve=False)recursively — 120/120 exact structural matches.Compatibility / Risk
_target_values, checkpoints, datasets, and runtime math are unchanged.examples/_base/paths are private implementation details and are not supported experiment entrypoints.Reviewer Notes
lint/check_recipe_composition.py, one representative base/entry pair such as SD3, then the documentation. The remaining YAML edits are the same mechanical extraction and are covered by 120/120 parity.Checklist