Replace errors.As with errors.AsType#8779
Open
ezekiel wants to merge 6 commits into
Open
Conversation
AssertErrorWraps NO LONGER has the side effect of unrapping the error, so added errors.AsType calls to tests where that effect was being relied-upon.
ezekiel
changed the title
jsha
reviewed
Jun 5, 2026
jsha
previously approved these changes
Jun 5, 2026
jsha
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces all uses of
errors.As()witherrors.AsType[]().One testing assertion,
AssertErrorWraps, was updating the error supplied to the errors.As call with the unwrapped error result. Changing to errors.AsType, I have NOT preserved that behavior, which seemed spooky-at-a-distance.AssertErrorWrapswas regularly followed-up with additional testing assertions on the presumably-unwrapped error, which cases just now have an additional errors.AsType call in their immediate vicinity to provide the unwrapped error.Fixes #8541