add param to keep showing from widget after flight#7
Open
maks-nuraphone wants to merge 2 commits intoletsar:masterfrom
Open
add param to keep showing from widget after flight#7maks-nuraphone wants to merge 2 commits intoletsar:masterfrom
maks-nuraphone wants to merge 2 commits intoletsar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new param to use with the source "from" Sidekick widget to allow choosing to keep showing the original source widget.
My thanks to @efortuna for submitting the bugfix that this PR essentially optionally disables as otherwise I would not have realised this functionality was possible with Sidekick.
The reason I want to be able to do this is to use Sidekick to implement an animation which temporarily replaces the target widget, as shown in the video below.
ps. My apologies for the laggyness at the end of the animation in the video, that just seems to be due to recording on the emulator, the actual animation is nice and smooth.