feat: pg_stat_statements JIT screen (hotkey x sub-screen) (#007)#142
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…add duration-sort AC Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…t + x-cycle note Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… fixes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Strengthen TestNew_StatementsJITView Msg assertion to pin the load-bearing jit=off empty-screen hint (Decision 4), mirroring TestNew_StatIOTimeView. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update existing regression tests broken by the new JIT menu item and x-cycle hop (dev-test-reviewer critical findings): menuPgss item count 6->7, statements_wal->statements_jit->statements_timings cycle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…assed round 2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…etrics Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 7th
pg_stat_statementssub-screen — JIT — under theXmenu (and thexcycle), showing per-statement JIT compilation cost. Last feature of release 0.11.0 (closes [007]).internal/query/statements.go):PgStatStatementsJITPG15(PG15/16, 13 cols) /PgStatStatementsJITDefault(PG17+, 15 cols, +deform) +SelectStatStatementsJITQuery(version) (string, int, [2]int, int);WHERE jit_functions > 0.internal/view/view.go):statements_jitentry —MinRequiredVersion PostgresV15,NotRecordable: true,OrderKey 2(gen_total) desc,jit=offhint inMsg; Configure() patches query/Ncols/DiffIntvl/UniqueKey per version.top/menu.go,top/config_view.go): 7th menu item +menuSelectcase;x-cyclewal → jit → timings.Columns:
user, database, gen_total, inline_total, opt_total, emit_total [,deform_total], gen,ms*, inline,ms*, opt,ms*, emit,ms* [,deform,ms*], functions*, queryid, query(*= interval/diffed).Versioning
PG15/16 base set; PG17/18 add
deform_total/deform,ms. PG<15 → "not supported" via the existingVersionOKruntime guard. TUI-only,NotRecordable(record/report deferred per the 0.11.0 TUI-first principle).Tests
TestSelectStatStatementsJITQuery(both version branches) + PG15+ gated exec sub-test.TestNew26→27,TestView_VersionOK(PG16 row) 26→27,Test_filterViewswantN +1; TUITest_selectMenuStyle/Test_statementsNextView/Test_switchViewToupdated.SDD artifacts
docs/features/007-feat-pg-stat-statements-jit/(user-spec, tech-spec, tasks, decisions — all validated/approved).🤖 Generated with Claude Code