Skip to content
This repository was archived by the owner on Mar 14, 2025. It is now read-only.

Terminal flickering when scrolloff is not zero#8

Open
quebin31 wants to merge 1 commit into
lenowski:masterfrom
quebin31:master
Open

Terminal flickering when scrolloff is not zero#8
quebin31 wants to merge 1 commit into
lenowski:masterfrom
quebin31:master

Conversation

@quebin31

@quebin31 quebin31 commented Jul 2, 2019

Copy link
Copy Markdown

I was getting some flickering when using Nuake, I think it was because scrolloff was set to 5. Setting it locally to zero fix flickering if global scrolloff is not zero.

@lenowski

lenowski commented Jul 7, 2019

Copy link
Copy Markdown
Owner

The problem with scrolloff is that it can't be set locally. If we add this to s:InitWindow(), after toggling Nuake, it will override the global value.

@quebin31

quebin31 commented Jul 7, 2019

Copy link
Copy Markdown
Author

Ohhh, but it's actually a problem when scrolloff isn't zero when you hit Ctrl+L to clean the terminal and start writing again it goes crazy, what can be done?

Edit: Maybe we can set scrolloff to zero while Nuake is active, then restore it's value when inactive.

@quebin31 quebin31 changed the title Set scrolloff to zero, fix flickering Terminal flickering when scrolloff is not zero Jul 7, 2019
@lenowski

lenowski commented Jul 7, 2019

Copy link
Copy Markdown
Owner

Firstly let's investigate the problem because, to be honest, I can use Ctrl+L without a problem ;)

Which version of vim/neovim do you use?

@quebin31

quebin31 commented Jul 8, 2019

Copy link
Copy Markdown
Author
NVIM v0.4.0-1234-g1b99aa8c5
Build type: RelWithDebInfo
LuaJIT 2.0.5
Compilation: /usr/bin/gcc-5 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DMIN_LOG_LEVEL=3 -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/home/travis/build/neovim/bot-ci/build/neovim/build/config -I/home/travis/build/neovim/bot-ci/build/neovim/src -I/home/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/usr/include -I/home/travis/build/neovim/bot-ci/build/neovim/build/src/nvim/auto -I/home/travis/build/neovim/bot-ci/build/neovim/build/include
Compiled by travis@travis-job-56dc1c5f-2993-496c-b265-d9ed100dbb09

Features: +acl +iconv +tui 
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/share/nvim"

Run :checkhealth for more info

I have scrolloff set to 5. I've tested it with zsh and bash and it starts to "flicker"

output

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants