Skip to content

ci: bump pnpm/action-setup to v6.0.8 (hotfixes backport)#5941

Open
akolson wants to merge 1 commit into
learningequality:hotfixesfrom
akolson:bump-pnpm-action-setup-hotfixes
Open

ci: bump pnpm/action-setup to v6.0.8 (hotfixes backport)#5941
akolson wants to merge 1 commit into
learningequality:hotfixesfrom
akolson:bump-pnpm-action-setup-hotfixes

Conversation

@akolson
Copy link
Copy Markdown
Member

@akolson akolson commented May 27, 2026

Backport of #5939 to hotfixes.

pnpm/action-setup@v6.0.3 has a regression (pnpm/action-setup#225) that ignores the pinned pnpm version and installs pnpm 11, which requires Node.js ≥22.13 and fails on our Node 20 runners. v6.0.8 restores correct handling of the packageManager-pinned version (10.33.0).

This is causing CI failures on PRs targeting hotfixes (e.g. #5926).

v6.0.3 carries a regression (pnpm/action-setup#225, learningequality#227) that ignores the
packageManager-pinned pnpm version and installs pnpm 11, which requires
Node.js >=22.13 and fails on our Node 20 runners. v6.0.7 restored self-update
to the packageManager-pinned version (10.33.0).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@akolson akolson requested a review from rtibblesbot May 27, 2026 07:02
Copy link
Copy Markdown
Contributor

@rtibblesbot rtibblesbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal backport — correct fix for the regression.

CI passing (Build frontend assets still in progress but unrelated to this change; all other checks pass).

No UI files changed — Phase 3 skipped.

  • praise: see inline

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Reviewed the pull request diff checking for:

  • Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
  • Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
  • Architecture: duplicated concerns, minimal interfaces, composition over inheritance
  • Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
  • Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
  • Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
  • Checked CI status and linked issue acceptance criteria
  • For UI changes: inspected screenshots for layout, visual completeness, and consistency

- uses: actions/checkout@v6
- name: Use pnpm
uses: pnpm/action-setup@v6.0.3
uses: pnpm/action-setup@v6.0.8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All 5 workflow files using pnpm/action-setup were updated consistently — no missed occurrences. Good thoroughness on the sweep.

@akolson akolson requested a review from rtibbles May 27, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants