friendly CPLnchErrs msgs from zipalign,jarsigner,aapt#4
Conversation
|
Thanks for your submission. #3 is a related issue. I'm wondering if a better overall check for all of the tools that brazenhead depends on would be more appropriate? Specifically, checking for the following items:
This might be a more specific approach to addressing the environment setup than the proposed solution. Thoughts? |
|
I agree, BUT the only problem with an overall check is that it may [be] hard to avoid relying on the Android SDK directory structure (which already changed once). I suppose simply being "smarter about looking for tools" would solve that (whatever that means). However, the proposed solution was done with a last line of defense mentality; If it blows up around here, it "perhaps" is [common reason] so people aren't left with parsing the stack trace and source code to deduce things. It's a matter of opinion. I'm just tired of remembering too many things every time I set it up on a new machine. Maybe updating the doc is the real solution, and if there are any error messages, they should just point to the doc? ~gjames |
|
"Be smarter" about looking for the tools means looking beneath |
A solution is not readily apparent when errors occur with “Unknown error (Windows says "The operation completed successfully.", but it did not.) (ChildProcess::LaunchError)”. This is typically resulted from simply not having the correct path variable setup.
This change outputs friendly error messages that suggest zipalign, jarsigner, and / or aapt are not in the user’s path when a ChildProcess::LaunchError occurs:
ERROR: Could not load manifest with aapt. Perhaps aapt is not in your path?
ERROR: Could not execute jarsigner command. Perhaps jarsigner is not in your path?
ERROR: Could not execute zipalign command. Perhaps zipalign is not in your path?