Skip to content

Add python formatting to checks - #271

Merged
arthurp merged 2 commits into
mainfrom
arthurp/add-python-formatting
Jul 31, 2026
Merged

Add python formatting to checks#271
arthurp merged 2 commits into
mainfrom
arthurp/add-python-formatting

Conversation

@arthurp

@arthurp arthurp commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Add python formatting (using black) to make check and make format.

@arthurp
arthurp changed the base branch from main to arthurp/update-docker-refs-for-black July 30, 2026 22:12
@arthurp
arthurp requested a review from ioeddk July 30, 2026 22:13
@arthurp

arthurp commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@ioeddk you are the only other person who has written significant python code. Are you OK with this formatting? I say "OK", because black is very strict and doesn't align with what everyone loves, but it generally works very well and is pretty standard now. That said, if you have any major concerns we can talk about adjusting setting or whatever.

@arthurp
arthurp force-pushed the arthurp/add-python-formatting branch from 3ace488 to 5f0c133 Compare July 30, 2026 22:18
@ioeddk

ioeddk commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@ioeddk you are the only other person who has written significant python code. Are you OK with this formatting? I say "OK", because black is very strict and doesn't align with what everyone loves, but it generally works very well and is pretty standard now. That said, if you have any major concerns we can talk about adjusting setting or whatever.

I'm OK with it. I can use any format as long as there are some automatic formatter.

@arthurp
arthurp changed the base branch from arthurp/update-docker-refs-for-black to main July 31, 2026 17:46
@arthurp
arthurp marked this pull request as ready for review July 31, 2026 17:46
@arthurp
arthurp requested a review from a team as a code owner July 31, 2026 17:46
@arthurp
arthurp force-pushed the arthurp/add-python-formatting branch from 5f0c133 to 1d5267f Compare July 31, 2026 17:47
@arthurp
arthurp force-pushed the arthurp/add-python-formatting branch from 1d5267f to 638f866 Compare July 31, 2026 17:49
@arthurp
arthurp merged commit 28f3245 into main Jul 31, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants