Quote tokens in delegating handlers to prevent parse errors#117
Merged
Conversation
Handlers that delegate (uv, env, arch, caffeinate) used " ".join() to reconstruct inner commands, losing shell quoting. Tokens with metacharacters (parens, semicolons) caused parse errors on re-parse. Use bash_join() to re-quote tokens, matching the pattern xargs and fd handlers already use. Closes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv,env,arch,caffeinate) used" ".join()to reconstruct inner commands for re-parsing, which strips shell quoting from tokensparse error: Syntax errorinstead of delegating to the inner handlerbash_join()which re-quotes tokens, matching the patternxargsandfdalready useExample:
uv run python -c "print('hello')"now correctly delegates to the python handler instead of failing with a parse error.Closes #109
See #116 for discussion of a more general fix to the delegation round-trip.