Do not use the system wctype() on Windows - #149
Open
kevinushey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
HAVE_ISWCTYPEandHAVE_WCTYPEare defined (both inwin32/config.hand by configure under MinGW), soTRE_USE_SYSTEM_WCTYPEis enabled. But the Windows CRT'swctype()has no"blank"class --wctype("blank")returns 0, so a pattern using[[:blank:]]fails to compile withREG_ECTYPE. The CRT'siswprint(L'\t')also incorrectly returns true, so[[:print:]]matches a tab.TRE already carries fixes for both in the
!TRE_USE_SYSTEM_WCTYPEpath --tre_isblank_func(), and the Windows tab check intre_isprint_func()imported from #106 -- but they are currently unreachable on Windows because the system-wctype path is selected instead.This excludes
_WIN32from theTRE_USE_SYSTEM_WCTYPEcondition so that TRE's own class-function table is used there, making those existing workarounds effective. R's bundled copy of TRE has shipped this opt-out for many years.No change on other platforms;
make checkpasses on macOS.