Fix pointer truncation and under-alignment in ALIGN() on LLP64 platforms - #148
Open
kevinushey wants to merge 1 commit into
Open
Fix pointer truncation and under-alignment in ALIGN() on LLP64 platforms#148kevinushey wants to merge 1 commit into
kevinushey wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALIGN()computes the padding needed to align a pointer by casting it throughlong. That has two problems on LLP64 platforms (64-bit Windows), wherelongis 32 bits:ALIGN(..., long)intre-mem.c,tre-match-parallel.c, andtre-match-approx.cstore pointers and structs containing pointers, which need 8-byte alignment, whilesizeof(long)is 4.This changes the cast to
size_tand introduces atre_aligned_tunion (pointer, function pointer,long long,double) used as the alignment type at all call sites.No functional change on LP64 platforms, where
longalready has pointer width.make checkpasses on macOS arm64 (clang). R's bundled copy of TRE has carried an equivalent fix for its 64-bit Windows builds for many years.