Improve xmalloc hash - #141
Merged
Merged
Conversation
* Rename ptr to addr and change its type to uintptr_t, since we're only using it as a unique key and not as a pointer. This should settle, once and for all, the use-after-free issue. * Rename bytes to size. * Simplify the search loop in hash_table_del(). * Make stats counters unsigned and static.
Count the number of inserts, hash collisions, and deletions, and report them along with the other statistics we already report.
* Increase the hash table size from 256 to 8191, which is prime. * Replace the hash function with Adler-32 modulo the hash table size. Hash collisions are now down from ~15% to less than 0.1% when running the test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wuse-after-freebuild warning #137)