fix: Correct module path to v3 - #435
Merged
Merged
Conversation
The go.mod on this branch still declared the module as github.com/launchdarkly/sdk-test-harness/v2 while the branch is tagged v3.x.x. Go requires the module path of a major version >= 2 to end in the matching /vN, so neither .../v2@v3.2.0-alpha.9 nor .../v3@v3.2.0-alpha.9 resolved. Anything importing the harness as a library could not fetch a v3 tag at all. Update the module directive and rewrite the 108 files that import it. Tags already published keep the old path; only tags cut after this change will resolve.
keelerm84
marked this pull request as ready for review
August 20, 2026 15:23
jsonbailey
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The go.mod on this branch still declared the module as
github.com/launchdarkly/sdk-test-harness/v2 while the branch is tagged
v3.x.x. Go requires the module path of a major version >= 2 to end in
the matching /vN, so neither .../v2@v3.2.0-alpha.9 nor
.../v3@v3.2.0-alpha.9 resolved. Anything importing the harness as a
library could not fetch a v3 tag at all.
Update the module directive and rewrite the 108 files that import it.
Tags already published keep the old path; only tags cut after this
change will resolve.
Note
Overview
Fixes Go module resolution for v3 tags by renaming the module from
github.com/launchdarkly/sdk-test-harness/v2to.../v3and rewriting internal imports to match.Go requires
/vNin the module path for major versions ≥ 2. The branch was already taggedv3.xwhilego.modstill said/v2, so neither.../v2@v3...nor.../v3@v3...could be fetched. Already-published tags keep the old path; only tags cut after this change will resolve as/v3.Reviewed by Cursor Bugbot for commit f4a06d8. Bugbot is set up for automated code reviews on this repo. Configure here.