Skip to content

feat: add client side bootstrap tests - #427

Open
joker23 wants to merge 1 commit into
v3from
skz/SDK-2834/bootstrap-tests
Open

feat: add client side bootstrap tests#427
joker23 wants to merge 1 commit into
v3from
skz/SDK-2834/bootstrap-tests

Conversation

@joker23

@joker23 joker23 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR will add initial client side bootstrap contract tests to the test harness


Open in Devin Review

Note

Overview
Adds client-side bootstrap contract testing to the SDK test harness: a new "bootstrap" capability, configuration wiring, and a full subtest suite that exercises pre-fetched allFlagsState-shaped flag data at SDK start.

The service spec now documents the capability and the clientSide.bootstrap object ($flagsState, $valid, replacement by the first live synchronizer payload). SDKConfigClientSideParams gains a bootstrap field with JSON serialization tests, and the client-side suite registers a bootstrap test group gated on CapabilityBootstrap.

New harness tests build bootstrap payloads via bootstrapPayloadBuilder, use withOfflineDataSystem() / live streaming setups, and cover immediate evaluation without network, initialization without waiting on the stream, metadata for analytics (not in all-flags), prerequisite events, null flag values → defaults, $valid: false still ingested, legacy payloads without $flagsState, and replace-not-merge when live data arrives.

Also fixes a read lock leak in mockld.StreamingService.makeXferFull when initial data is not FDv2 (adds RUnlock before early return).

Reviewed by Cursor Bugbot for commit 3962a6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23

joker23 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@joker23
joker23 marked this pull request as ready for review August 17, 2026 17:27
@joker23
joker23 requested a review from a team as a code owner August 17, 2026 17:27

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant