feat: add client side bootstrap tests - #427
Open
joker23 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@cursor review |
joker23
marked this pull request as ready for review
August 17, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add initial client side bootstrap contract tests to the test harness
Note
Overview
Adds client-side bootstrap contract testing to the SDK test harness: a new
"bootstrap"capability, configuration wiring, and a full subtest suite that exercises pre-fetchedallFlagsState-shaped flag data at SDK start.The service spec now documents the capability and the
clientSide.bootstrapobject ($flagsState,$valid, replacement by the first live synchronizer payload).SDKConfigClientSideParamsgains abootstrapfield with JSON serialization tests, and the client-side suite registers a bootstrap test group gated onCapabilityBootstrap.New harness tests build bootstrap payloads via
bootstrapPayloadBuilder, usewithOfflineDataSystem()/ live streaming setups, and cover immediate evaluation without network, initialization without waiting on the stream, metadata for analytics (not in all-flags), prerequisite events, null flag values → defaults,$valid: falsestill ingested, legacy payloads without$flagsState, and replace-not-merge when live data arrives.Also fixes a read lock leak in
mockld.StreamingService.makeXferFullwhen initial data is not FDv2 (addsRUnlockbefore early return).Reviewed by Cursor Bugbot for commit 3962a6f. Bugbot is set up for automated code reviews on this repo. Configure here.