Skip to content

chore: Add Vue SDK data-saving-mode example - #1852

Open
joker23 wants to merge 2 commits into
mainfrom
skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example
Open

chore: Add Vue SDK data-saving-mode example#1852
joker23 wants to merge 2 commits into
mainfrom
skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example

Conversation

@joker23

@joker23 joker23 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This PR will add in a FDv2 example for vue client sdk


Note

Overview
Adds a Vue 3 + Vite example that opts into FDv2 via dataSystem: {} and lets you switch connection mode, streaming, and context at runtime.

The app is registered as a yarn workspace, built and type-checked in Vue CI, and included in release-please so the SDK version in the example stays in sync.

Also corrects React data-saving-mode docs: empty dataSystem uses the browser one-shot default (fetch once, no live updates) rather than streaming.

Reviewed by Cursor Bugbot for commit 076ac60. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from 4ff300f to a855db5 Compare August 12, 2026 21:10
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26360 bytes
Compressed size limit: 29000
Uncompressed size: 129188 bytes

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26360 bytes
Compressed size limit: 29000
Uncompressed size: 129188 bytes

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179887 bytes
Compressed size limit: 200000
Uncompressed size: 833430 bytes

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32444 bytes
Compressed size limit: 34000
Uncompressed size: 116232 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32142 bytes
Compressed size limit: 34000
Uncompressed size: 114604 bytes

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 41502 bytes
Compressed size limit: 44000
Uncompressed size: 224541 bytes

@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from a855db5 to 371b130 Compare August 12, 2026 21:11
@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from 371b130 to 20eb1d6 Compare August 13, 2026 15:18
@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from 20eb1d6 to a5a94b8 Compare August 14, 2026 15:07
@joker23
joker23 marked this pull request as ready for review August 14, 2026 15:22
@joker23
joker23 requested a review from a team as a code owner August 14, 2026 15:22

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from a5a94b8 to 3b15657 Compare August 14, 2026 18:20
cursor[bot]

This comment was marked as resolved.

Base automatically changed from skz/SDK-2903/migrate-vue-sdk-getting-started-example to main August 14, 2026 18:35
@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from 3b15657 to ea693e8 Compare August 14, 2026 18:35
devin-ai-integration[bot]

This comment was marked as resolved.

@joker23
joker23 marked this pull request as draft August 14, 2026 20:39
@joker23
joker23 force-pushed the skz/SDK-2904/migrate-vue-sdk-data-saving-mode-example branch from ea693e8 to 076ac60 Compare August 18, 2026 17:50
@joker23
joker23 marked this pull request as ready for review August 20, 2026 20:33

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 076ac60. Configure here.

"typescript": "^5.5.3",
"vite": "^5.4.1"
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfile omitted for new workspace

High Severity

The new @launchdarkly/vue-client-sdk-example-data-saving-mode workspace and its vue-tsc dependency are added without a matching yarn.lock update. CI uses Yarn immutable installs, so yarn workspaces focus for this example will fail before the new build and type-check steps run.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 076ac60. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant