Skip to content

test: bump remaining 1ms channel-wait timeouts to 1s #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-zeisler wants to merge 2 commits into
base: v7
Choose a base branch
from
Open

test: bump remaining 1ms channel-wait timeouts to 1s #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bba08e
test: bump remaining 1ms channel-wait timeouts to 1s
aaron-zeisler Jul 13, 2026
68f0b7f
Merge branch 'v7' into aaronz/fix-remaining-1ms-channel-timeouts
aaron-zeisler Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/broadcasters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func testBroadcasterGenerically[V any](t *testing.T, broadcasterFactory func() *
ch2 := b.AddListener()

b.RemoveListener(ch1)
th.AssertChannelClosed(t, ch1, time.Millisecond)
th.AssertChannelClosed(t, ch1, time.Second)

value := valueFactory()
b.Broadcast(value)
Expand Down
2 changes: 1 addition & 1 deletion internal/flag_tracker_impl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestFlagValueChangeListener(t *testing.T) {
ch3 := tracker.AddFlagValueChangeListener(flagKey, otherUser, ldvalue.Null())

tracker.RemoveFlagValueChangeListener(ch2) // just verifying that the remove method works
th.AssertChannelClosed(t, ch2, time.Millisecond)
th.AssertChannelClosed(t, ch2, time.Second)

th.AssertNoMoreValues(t, ch1, timeout)
th.AssertNoMoreValues(t, ch3, timeout)
Expand Down
4 changes: 2 additions & 2 deletions ldclient_listeners_fdv2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func TestFlagTrackerV2(t *testing.T) {
sharedtest.ExpectFlagChangeEvents(t, ch2, alwaysTrueFlag.Key)

p.client.GetFlagTracker().RemoveFlagChangeListener(ch1)
th.AssertChannelClosed(t, ch1, time.Millisecond)
th.AssertChannelClosed(t, ch1, time.Second)

jsonFlag, _ = json.Marshal(alwaysTrueFlag)
p.protocol.WithPutObject(subsystems.PutObject{
Expand All @@ -125,7 +125,7 @@ func TestFlagTrackerV2(t *testing.T) {
ch3 := p.client.GetFlagTracker().AddFlagValueChangeListener(alwaysTrueFlag.Key, otherUser, ldvalue.Null())

p.client.GetFlagTracker().RemoveFlagValueChangeListener(ch2) // just verifying that the remove method works
th.AssertChannelClosed(t, ch2, time.Millisecond)
th.AssertChannelClosed(t, ch2, time.Second)

th.AssertNoMoreValues(t, ch1, timeout)
th.AssertNoMoreValues(t, ch3, timeout)
Expand Down
4 changes: 2 additions & 2 deletions ldclient_listeners_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func TestFlagTracker(t *testing.T) {
sharedtest.ExpectFlagChangeEvents(t, ch2, flagKey)

p.client.GetFlagTracker().RemoveFlagChangeListener(ch1)
th.AssertChannelClosed(t, ch1, time.Millisecond)
th.AssertChannelClosed(t, ch1, time.Second)

p.testData.Update(p.testData.Flag(flagKey))

Expand All @@ -101,7 +101,7 @@ func TestFlagTracker(t *testing.T) {
ch3 := p.client.GetFlagTracker().AddFlagValueChangeListener(flagKey, otherUser, ldvalue.Null())

p.client.GetFlagTracker().RemoveFlagValueChangeListener(ch2) // just verifying that the remove method works
th.AssertChannelClosed(t, ch2, time.Millisecond)
th.AssertChannelClosed(t, ch2, time.Second)

th.AssertNoMoreValues(t, ch1, timeout)
th.AssertNoMoreValues(t, ch3, timeout)
Expand Down
2 changes: 1 addition & 1 deletion ldfiledatav2/file_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func TestClosingSynchronizerClosesResultsChannel(t *testing.T) {
<-resultChan
sync.Close()

th.AssertChannelClosed(t, resultChan, time.Millisecond, "result channel should be closed")
th.AssertChannelClosed(t, resultChan, time.Second, "result channel should be closed")
})
}

Expand Down
4 changes: 2 additions & 2 deletions testhelpers/ldtestdatav2/test_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func TestSupportsMultipleSynchronizers(t *testing.T) {

sync2.Close()

th.AssertChannelClosed(t, resultChan2, time.Millisecond, "result channel should be closed")
th.AssertChannelClosed(t, resultChan2, time.Second, "result channel should be closed")

td.Update(td.Flag("flag1").On(false))

Expand Down Expand Up @@ -285,5 +285,5 @@ func TestClosingSynchronizerClosesResultChannel(t *testing.T) {

sync.Close()

th.AssertChannelClosed(t, resultChan, time.Millisecond, "result channel should be closed")
th.AssertChannelClosed(t, resultChan, time.Second, "result channel should be closed")
}
Loading