Skip to content

chore: use valueOf instead of deprecated boxing constructors in FlagTest #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abelonogov-ld wants to merge 1 commit into from
Closed

chore: use valueOf instead of deprecated boxing constructors in FlagTest #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions launchdarkly-android-client-sdk/src/test/java/com/launchdarkly/sdk/android/FlagTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public void variationIsSerialized() {
public void variationIsDeserialized() {
final String jsonStr = "{\"version\": 99, \"variation\": 2}";
final Flag r = gson.fromJson(jsonStr, Flag.class);
assertEquals(new Integer(2), r.getVariation());
assertEquals(Integer.valueOf(2), r.getVariation());
}

@Test
Expand Down Expand Up @@ -243,12 +243,12 @@ public void debugEventsUntilDateIsSerialized() {
public void debugEventsUntilDateIsDeserialized() {
final String jsonStr = "{\"version\": 99, \"debugEventsUntilDate\": 12345}";
final Flag r = gson.fromJson(jsonStr, Flag.class);
assertEquals(new Long(12345L), r.getDebugEventsUntilDate());
assertEquals(Long.valueOf(12345L), r.getDebugEventsUntilDate());

// Test long sized number
final String jsonStrl = "{\"version\": 99, \"debugEventsUntilDate\": 2500000000}";
final Flag rl = gson.fromJson(jsonStrl, Flag.class);
assertEquals(new Long(2500000000L), rl.getDebugEventsUntilDate());
assertEquals(Long.valueOf(2500000000L), rl.getDebugEventsUntilDate());
}

@Test
Expand Down
Loading