Skip to content

chore: stop unit test OOM from a spinning synchronizer loop #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 3 commits into from
Aug 18, 2026
Merged

chore: stop unit test OOM from a spinning synchronizer loop #390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09513ce
chore: stop unit test OOM from a spinning synchronizer loop
abelonogov-ld Aug 17, 2026
7b0f1b9
chore: drop unrelated deprecation cleanup from this branch
abelonogov-ld Aug 17, 2026
3fd6c46
chore: move test JVM heap size to its own branch
abelonogov-ld Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ...kly-android-client-sdk/src/test/java/com/launchdarkly/sdk/android/FDv2DataSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,17 +663,23 @@ public void recoveryResetsToFirstAvailableSynchronizer() throws Exception {
AtomicInteger firstCallCount = new AtomicInteger(0);
AtomicInteger secondCallCount = new AtomicInteger(0);

MockQueuedSynchronizer firstSync = new MockQueuedSynchronizer(
FDv2SourceResult.changeSet(makeChangeSet(false), false),
interrupted());
MockQueuedSynchronizer secondSync = new MockQueuedSynchronizer(
FDv2SourceResult.changeSet(makeChangeSet(false), false));

// Each factory must build a fresh synchronizer, as the real ones do. SourceManager closes
// the synchronizer it is switching away from, and a closed one reports SHUTDOWN
// immediately, so handing the same instance back on every recovery would spin this loop.
FDv2DataSource dataSource = buildDataSource(sink,
Collections.emptyList(),
Arrays.asList(
() -> { firstCallCount.incrementAndGet(); return firstSync; },
() -> { secondCallCount.incrementAndGet(); return secondSync; }),
() -> {
firstCallCount.incrementAndGet();
return new MockQueuedSynchronizer(
FDv2SourceResult.changeSet(makeChangeSet(false), false),
interrupted());
},
() -> {
secondCallCount.incrementAndGet();
return new MockQueuedSynchronizer(
FDv2SourceResult.changeSet(makeChangeSet(false), false));
}),
1, 2);

AwaitableCallback<Boolean> startCallback = startDataSource(dataSource);
Expand Down
Loading