fix: include sidecar eval tokens in optimizer totals#1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizer and eval token displays now count sidecar-backed trader decisions instead of showing only the mutator/judge slice. Eval reports fall back to
eval_runs.actual_*_tokenswhen no linkedmodel_callsexist, cycle summaries add those linked fallback actuals to the cycle meter, and cycle exports include per-experiment token counts in both JSON and markdown timelines.The aggregation keeps
model_call_counttruthful: fallback-only runs still report zero model-call rows, and cycle totals skip fallback actuals for linked evals that already have model-call rows to avoid double counting.Verification
cargo test -p xvision-engine eval::report::tests::aggregate_run_token_totals_falls_back_to_eval_run_actualscargo test -p xvision-engine autooptimizer::cycle_runs::testscargo test -p xvision-engine autooptimizer::cycle_export::testscargo test -p xvision-cli commands::eval::tests::status_line_fallback_tokens_render_without_model_callsgit diff --checkReview