Skip to content

feat(settings): add Byreal Spot venue surface to Settings → Brokers#1107

Open
latentwill wants to merge 1 commit into
mainfrom
feat/byreal-spot-venue
Open

feat(settings): add Byreal Spot venue surface to Settings → Brokers#1107
latentwill wants to merge 1 commit into
mainfrom
feat/byreal-spot-venue

Conversation

@latentwill

Copy link
Copy Markdown
Owner

What

Adds Byreal Solana Spot credential management to Settings → Brokers. The trading capability already shipped via PR #1082 (ByrealSpotSurface, LiveVenue::ByrealSpot, SafetyGate, byreal_spot_marks.rs). This is the operator-facing credential surface only.

Changes

Backend

  • BrokersReport gains byreal_spot: BrokerEntry field
  • BrokersSecretsFile gains [byreal_spot] table
  • New types: ByrealSpotCredentials, SetByrealSpotReq, ByrealSpotStored
  • byreal_spot_entry() constructor detecting BYREAL_SPOT_PRIVATE_KEY / BYREAL_SPOT_NETWORK env vars
  • set_byreal_spot() / clear_byreal_spot() with audit logging
  • Routes: POST/DELETE /api/settings/brokers/byreal-spot

Frontend

  • New ByrealSpotBrokerCard component (private key + network toggle)
  • Mirrors the existing ByrealBrokerCard but without an account field (spot resolves wallet from the byreal-cli keystore)
  • API helpers: setByrealSpotCredentials() / clearByrealSpotCredentials()
  • 3 new tests in brokers.test.tsx

Verification

  • Backend: 27 engine broker tests pass, 4 dashboard integration tests pass
  • TypeScript: compiles cleanly
  • Closes xvision-1gho

Adds byreal_spot to BrokersReport + BrokersSecretsFile with:
- ByrealSpotCredentials store (private_key + network, no account field)
- set/clear routes at POST/DELETE /api/settings/brokers/byreal-spot
- byreal_spot_entry() constructor detecting BYREAL_SPOT_PRIVATE_KEY /
  BYREAL_SPOT_NETWORK env vars
- ByrealSpotBrokerCard in Settings → Brokers UI (mirrors perps card)

The trading capability shipped via PR #1082 (ByrealSpotSurface,
LiveVenue::ByrealSpot, SafetyGate). This is the operator-facing
credential surface only.

Closes xvision-1gho.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants