fix(security): add CSRF protection and complete all 10 security fixes - #64
Merged
Conversation
- Add CSRF middleware with server-side token store (csrf.go) - Wire up CSRF in main.go with /api/csrf/token endpoint - Add X-CSRF-Token header to CORS AllowHeaders - Update frontend api.ts to fetch and inject CSRF tokens - Fix IP whitelist middleware signature and add hot-reload version tracking - Fix validatePath to use fmt.Errorf instead of invalid filepath.Skip - Fix config.go imports (remove filepath, add fmt) - Add config version counter to ConfigManager - All previous 9 security fixes included (proxy headers, rate limiter, CORS, config disclosure, health endpoint, validation, CIDR caching, logging)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes all 10 security fixes identified in the security audit:
Fix #10 (This PR): CSRF Protection
Other Fixes Included (from develop branch)
Testing
Threat Model Note
CSRF protection is defense-in-depth for this setup. CloudPass uses IP whitelisting (no sessions/cookies for auth). The CSRF token is per-session and validated server-side.