fix(multipass): use key=value format for multipass set commands - #58
Merged
Conversation
laolusrael
force-pushed
the
fix/multipass-set-keyvalue
branch
from
April 23, 2026 12:43
8debb4c to
f2b485f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
PUT /api/instances/{name}/resourcesand all othermultipass setcalls failing because key and value were passed as separate arguments instead ofkey=value.Root Cause
Multipass
setcommand requireskey=valueas a single argument:This caused the error:
Changes
SetInstanceResources— CPU, memory, and disk now usekey=valueformatkey=valueformatparseMemoryStringusesParseFloatto handle"4.0G"CombinedOutput()surfaces real multipass error messagesmultipass setfor values that actually changedmultipass setsyntax in API referenceFiles Changed
api/internal/multipass/client.godocs/MULTIPASS_API_REFERENCE.mdTest Results
go test -tags ci ./...— Pass