fix(instances): accept decimals and improve SetInstanceResources error handling - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
PUT /api/instances/{name}/resourcesfailing with generic errors and rejecting valid decimal memory/disk values.Changes
Accept decimal values in memory/disk strings
parseMemoryStringnow usesstrconv.ParseFloatinstead ofstrconv.ParseInt"4.0G","25.0G","2.5G"that multipass acceptsCapture stderr from multipass commands
SetInstanceResourcesnow usescmd.CombinedOutput()instead ofcmd.Output()"setting must be a positive integer") instead of generic"exit status 1"Skip unchanged values
multipass setfor values that actually changedTest Results
go test -tags ci ./...-- Passgofmt -d .-- CleanFixes
{"error":"invalid_request","message":"invalid memory format"}for"4.0G"{"error":"multipass_error","message":"failed to set CPU: exit status 1"}by surfacing real errors