fix(instances): correct stopped VM resource reporting and add tests - #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the endpoint
/api/instances/{name}returning incorrect resource values (memory: "0 B",disk: "0 B") for stopped instances.Problem
When a VM is stopped,
multipass inforeportsmemory.total: 0anddisk.total: 0. The existing fallback logic checkedinstance.Memory == ""andinstance.Disk == "", butformatBytes(0)returns"0 B"-- so the fallback tomultipass getnever triggered.Fix
memBytesanddiskBytesvalues (before formatting) for zero instead of checking the formatted stringsmultipass get local.<name>.{cpus,memory,disk}for stopped VMsAlso Includes
GetHostInfo()usesmultipassDataDir()to locate VM data directoryLibrary/Application Support/multipassdpathsUpdateResourcestests +HostHandlertestsGetInstancereturns proper error instead ofnil, nilmultipassis unavailableTest Results
go test -tags ci ./...-- Passgofmt -d .-- Cleannpx vitest --run-- 15/15 passnpm run lint-- Cleannpm run build-- Success