Thread through the ability to allow grid objects to own memory#144
Open
Yurlungur wants to merge 19 commits into
Open
Thread through the ability to allow grid objects to own memory#144Yurlungur wants to merge 19 commits into
Yurlungur wants to merge 19 commits into
Conversation
…o jmm/unstructured-grid-1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This MR is on the path to supporting Sesame grids in singularity-eos. In this MR, I extend the spiner infrastructure so that Grid1D objects can own memory. This required extending the serialization routines and
getOnDeviceandfinalizeroutines to call the appropriate grid objects as well. This ended up being a sufficiently sweeping change/large diff that I decided to split it out into a separate MR to get reviewed/tested by the CI.One note I want to make that is an engineering decision that I'm not sure I want to keep: Usually we assume all operations in spiner are shallow. However, this "always shallow" model could get cumbersome if multiple databoxes each want to share Grid objects, which might themselves own array data. We have a few solutions to this:
I chose path 1 for now. But I will at least revisit this decision in the subsequent MR when I add non-uniformly spaced grids for real.
PR Checklist
plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: