Cleanup build and tests#74
Merged
Merged
Conversation
Yurlungur
requested review from
AstroBarker,
buechlerm,
chadmeyer and
mauneyc-LANL
June 2, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this MR, I move from catch2 v2 to catch2 v3 and add a missing include guard in the cmake for spiner. This makes the code/tests more inline with singularity-eos and also makes the cmake actually function for codes that use singularity-opac as a submodule (at least on CPU). The build system still needs updating to be more inline with how singularity-eos does things, but this is a start.
Generative AI was used to assist in the migration.