Towards Multigroup API#71
Conversation
|
@pdmullen is this ready for review? |
|
Looks like |
|
Since the gray MeanOpacity class has been extended to multigroup here, does it make sense to support overloads of the opacity accessors that don't take a group index in the event that there is only one group (i.e. the tables are gray)? Or should that be a concern of the downstream codes? |
Yurlungur
left a comment
There was a problem hiding this comment.
Some nitpicks but my comments are non-blocking.
These exist in this changeset already, I believe. However, I did have some concern that someone might accidentally use them with a multigroup opacity (ngroups > 1) which would result in the behavior of accessing the zeroth group, not a true frequency integrated opacity. Therefore, I added a |
|
👍 merge when ready |
RyanWollaeger
left a comment
There was a problem hiding this comment.
LGTM - one minor residual question, but feel free to ignore.
This PR and PR summary text used generative AI.
Add photon multigroup absorption & scattering API
Adds a multigroup radiation API for photons by unifying multigroup support into the existing mean-opacity classes
(absorption and scattering) rather than adding new types. With ngroups=1 and bounds [0, ∞) these reduce exactly to
gray opacities; ngroups>1 enables multigroup transport.
tables
(GroupOfNu, ...FromNu); non-CGS wrappers preserved
Full suite passes with tests + HDF5 on (686 assertions, 36 cases). Deferred to follow-ups: neutrino multigroup,
integrated multigroup emissivity.