update ports-of-call, spiner, remove mpark variant#68
Merged
Conversation
Yurlungur
requested review from
RyanWollaeger,
adamdempsey90,
lroberts36 and
pdmullen
January 22, 2026 20:00
Yurlungur
commented
Jan 22, 2026
Comment on lines
-83
to
-88
| # Patches variant to be compatible with cuda | ||
| # Assumes "patch" is present on system | ||
| message(STATUS "Patching mpark::variant to support GPUs") | ||
| execute_process(COMMAND patch -N -s -V never | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/utils/variant/include/mpark/variant.hpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/utils/cuda_compatibility.patch) |
Collaborator
Author
There was a problem hiding this comment.
this should simplify downstream builds a bit.
pdmullen
approved these changes
Jan 22, 2026
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates singularity-opac's dependencies to be inline with singularity-eos. I update spiner (which I think doesn't matter) and ports-of-call (which does) and remove mpark::variant in preference of
PortsOfCall::Variant.