Conversation
Collaborator
Author
|
Thanks @chadmeyer for your help figuring this out |
buechlerm
approved these changes
Jul 16, 2026
Co-authored-by: Adam M. Dempsey <adempsey@lanl.gov>
adamdempsey90
approved these changes
Jul 16, 2026
Collaborator
Author
|
Tests passing on darwin. Pulling the trigger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A user discovered that the
InternalEnergyFromDensityPressurecall was failing to produce the correct internal energy for some EOS calls for JWL. The problem in question was a shock tube described in this paper. The issue it turns out was that singularity-eos generically uses a root find for this call and it picks the bounds for the root find based on the max and min temperature. But JWL is not a thermodynamically consistent EOS and the result was that the lower bound is below the reference temperature curve.In this case, the fix is easy: simply replace the root find with the analytic solution, since JWL has an analytically invertable sie(rho, P). I implement the fix and add tests to JWL to check that it's functioning properly.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: