Skip to content

fix(web): improve DSL export feedback#39409

Merged
lyzno1 merged 3 commits into
mainfrom
codex/fix-dsl-export-feedback
Jul 22, 2026
Merged

fix(web): improve DSL export feedback#39409
lyzno1 merged 3 commits into
mainfrom
codex/fix-dsl-export-feedback

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • render Base UI promise toast loading states with the Dify spinner treatment
  • split direct app DSL export from the Workflow and Advanced Chat secret preflight using generated contracts
  • expose one mutation lifecycle across preflight and export, and surface pending feedback in App cards, the app sidebar, and Agent v2
  • keep App card action menus consistently sized without coupling tests to CSS

Why

DSL exports could appear idle while requests were pending. Workflow callers also fetched the full draft only to inspect secret environment variables, while Agent v2 does not use workflow drafts.

User impact

Users now get immediate loading feedback and duplicate export requests are prevented. Workflow exports only read the smaller environment-variable endpoint before deciding whether secret confirmation is required.

Validation

  • cd web && vp test run app/components/app/__tests__/use-export-app-dsl.spec.tsx app/components/apps/__tests__/app-card.spec.tsx app/components/app-sidebar/app-info/__tests__/use-app-info-actions.spec.ts app/components/app-sidebar/app-info/__tests__/app-info-detail-panel.spec.tsx app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx features/agent-v2/roster/components/__tests__/agent-roster-list.spec.tsx features/agent-v2/agent-detail/__tests__/navigation.spec.tsx app/components/workflow/__tests__/dsl-export-confirm-modal.spec.tsx
  • cd web && pnpm type-check
  • cd packages/dify-ui && vp test run --project unit src/toast/__tests__/index.spec.tsx
  • cd packages/dify-ui && vp test --project storybook --run src/toast/index.stories.tsx
  • cd packages/dify-ui && pnpm type-check
  • git diff --check

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 22, 2026
@lyzno1
lyzno1 marked this pull request as ready for review July 22, 2026 09:30
@lyzno1
lyzno1 enabled auto-merge July 22, 2026 09:30
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. refactor labels Jul 22, 2026
@lyzno1
lyzno1 marked this pull request as draft July 22, 2026 09:32
auto-merge was automatically disabled July 22, 2026 09:32

Pull request was converted to draft

@lyzno1
lyzno1 marked this pull request as ready for review July 22, 2026 09:34
@lyzno1
lyzno1 enabled auto-merge July 22, 2026 09:34
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 62db37c Jul 22, 2026
40 checks passed
@lyzno1
lyzno1 deleted the codex/fix-dsl-export-feedback branch July 22, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants