Round 2 (A): Brookes code page, documentation sidebar + corrections, citation policy - #657
Merged
Merged
Conversation
…rt A) Brookes access code - brookescode_form.html: restyled as a focused card (same pattern as login); explains what a code is and that it's a one-year licence per researcher; labelled input; "Apply code" / "Not now" (the latter keeps name=cancel value=Cancel, which BrookesCodeForm.clean and the view depend on); Brookes-support link for broken codes. - Deep link to the exact Brookes product for the family being unlocked: brookes/utils.py maps the four chargeable families to the per-instrument access-code products listed on brookespublishing.com/product/cdi/, keyed by family name so it holds across deployments; anything else falls back to the general Web-CDI page. - no_brookes_code.html (shown instead of the add-administrations dialog when the group's instrument has no active licence): same copy, same deep link, plus "Enter your code" and support links. AdminNew passes the URLs. Documentation - Sticky sidebar table of contents with scroll-spy on wide screens, folding to a two-column Contents card on narrow ones (sections stay expanded: a manual should be readable top-to-bottom and Ctrl-F-able). - Corrected stale UI names: Instruments page (not "My CDI Forms"), "+ New administration group" page (not a "Set Up dialog"), Add Administrations, tick-row + Re-administer, row edit (pencil) for Local Lab ID and Opted-out-of-sharing, dashboard cards / group switcher, current Download All / Download menu item names. - Access-code section added under Selecting instruments. - PDF version link removed (the PDF will only drift further from the UI). - New "How to cite" section. Citations - webcdi/_how_to_cite.html: one shared block used by About and the docs. Three explicit rules (platform -> deMayo et al. 2021; CAT -> Kachergis et al. 2022; instruments -> Marchman, Dale & Fenson 2023 manual) with full references and verified DOI / publisher links. Theme: auth-card-wide, eyebrow, form-error, auth-actions/foot helpers; doc sidebar styles; .wcdi-ref hanging indent. Both theme copies kept in sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part A of the round-2 feedback, against
phases1to11. Templates/CSS only (plus one tiny view context addition). Design proposal: https://claude.ai/code/artifact/7a4700c1-5e9d-4d52-ba64-299ee58981c6Brookes access-code page
brookes/utils.pymaps family name → product URL, with the general Web-CDI page as fallback. Keyed by name, not pk, so it holds on the EU server's database too.name=cancel value=Cancel—BrookesCodeForm.cleanand the view key on that value to remove the family from the researcher's list (same behaviour as the old Cancel; the footer now says so).Documentation
Citations
webcdi/_how_to_cite.html— one shared block used by About and the docs. Three explicit rules: platform → deMayo et al. (2021); CAT → Kachergis et al. (2022); instruments → Marchman, Dale & Fenson (2023) manual. Full references; DOIs verified resolving. Please eyeball the author lists — you're on two of them.Verification
🤖 Generated with Claude Code