Restore the CAT progress counter (clipped by the facelift's thin bar) - #656
Open
mcfrank wants to merge 1 commit into
Open
Restore the CAT progress counter (clipped by the facelift's thin bar)#656mcfrank wants to merge 1 commit into
mcfrank wants to merge 1 commit into
Conversation
The facelift restyled .progress to a thin 10px bar with overflow:hidden. The CAT progress counter was absolutely positioned *inside* that bar (it assumed the old ~20px bar height), so the restyled bar clipped the text away entirely — the number was still computed, just invisible. Reported by the French CAT group originally and noticed missing in testing. Move the counter onto its own centered line just below the bar (both the remote cat_form.html and the in-browser cat_form_browser.html). Verified in browser mode: shows "1 of 50 (maximum)" and increments as items are answered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of the stack (base
phase11-ci) since the jsCat PR isn't merged yet — it needs both the facelift (which introduced the thin progress bar) and the jsCat CAT templates.The bug
Henry noticed the CAT progress-bar counter (the "N of MAX (maximum)" text the French CAT group asked for) had disappeared. It wasn't removed — it was clipped invisible. The facelift restyled
.progressto a thin 10px bar withoverflow:hidden, but the counter (.progress-bar-title) was absolutely positioned inside that bar, assuming the old ~20px height. The restyled bar clips it away. The number was still being computed correctly the whole time ("1 of 50 (maximum)"), just invisible.The fix
Move the counter onto its own centered line just below the bar, in both CAT templates:
cat_form.html(remote engine)cat_form_browser.html(in-browser jsCat engine)Dropped the absolute positioning /
overflow:hidden/ bar-height assumptions; it's now a normal centered line under the thin bar.Verification
Rendered the browser-engine CAT locally: the counter shows "1 of 50 (maximum)" below the bar and increments correctly (answering advanced it to "2 of 50", bar → 4%). Both engines share the identical fix.
Merge note
The two files here also live in the jsCat PR (#622). Whichever way the stack lands, keep this version (counter below the bar).
🤖 Generated with Claude Code