1/6 Tech debt: dev docs, .env template, compose hardening, settings refactor - #617
Open
mcfrank wants to merge 6 commits into
Open
1/6 Tech debt: dev docs, .env template, compose hardening, settings refactor#617mcfrank wants to merge 6 commits into
mcfrank wants to merge 6 commits into
Conversation
.env.example documents every env var settings.py reads, with values that work out of the box with docker-compose. DEVELOPMENT.md is the setup guide (build, migrate, populate, day-to-day commands). The .gitignore .env* pattern needed an exception so the example can be tracked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The unpinned postgres image began pulling Postgres 18, which changed
its data-directory layout and refuses the volume mount at
/var/lib/postgresql/data. The db healthcheck was a no-op ("exit 0"),
so web could start before the database accepted connections and
crash with a DNS/connection error; depends_on now waits for
pg_isready. Also drops the obsolete compose "version" key.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Leftover from the pre-R-API python (catsim) CAT implementation; nothing references it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ALLOWED_HOSTS, ADMINS, and TRUSTED_ORIGINS shared triplicated string-mangling; that logic now lives in two documented parser functions accepting both the quoted-literal and unquoted EB shorthand formats, with identical results (verified by diffing a full settings dump before/after — the only change is that the leaked TEMP_ADMINS/TEMP_ALLOWED_HOSTS intermediates are gone). DEBUG used bool(os.environ.get(...)), which is True for ANY non-empty string including "False"; it now uses the existing is_true() helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9415972 | Triggered | Generic Password | 8ba9af7 | .env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This was referenced Jul 9, 2026
Collaborator
|
No is uncovered. This in an example password in an example file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of a six-PR stack (merge in order: 1→6). Full-stack preview for clicking around: http://webcdi-preview.us-west-2.elasticbeanstalk.com — leave whole-picture comments on the draft rollup PR; leave line comments here.
.gitignore.env*pattern needed a!.env.exampleexception.postgres:16(unpinned image started pulling Postgres 18, which rejects the old volume layout), replaces the no-op db healthcheck withpg_isready, and makeswebwait onservice_healthy— fixes the startup race.ALLOWED_HOSTS/ADMINS/TRUSTED_ORIGINSbecomes two documented parser functions (verified byte-identical settings dump before/after). Fixes a real bug:DEBUG = bool(os.environ.get("DEBUG", False))was True for ANY non-empty value, includingDEBUG=False.stopper.bak(pre-R-API catsim leftover).🤖 Generated with Claude Code