fix(langgraph): run all tasks when maxConcurrency is 1 - #2665
Open
Pushkar Verma (pushkarverma3698) wants to merge 1 commit into
Open
fix(langgraph): run all tasks when maxConcurrency is 1#2665Pushkar Verma (pushkarverma3698) wants to merge 1 commit into
Pushkar Verma (pushkarverma3698) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: cd0d9e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@langchain/langgraph-checkpoint
@langchain/langgraph-checkpoint-mongodb
@langchain/langgraph-checkpoint-postgres
@langchain/langgraph-checkpoint-redis
@langchain/langgraph-checkpoint-sqlite
@langchain/langgraph-checkpoint-validation
create-langgraph
@langchain/langgraph-api
@langchain/langgraph-cli
@langchain/langgraph
@langchain/langgraph-cua
@langchain/langgraph-supervisor
@langchain/langgraph-swarm
@langchain/langgraph-ui
@langchain/langgraph-sdk
@langchain/angular
@langchain/react
@langchain/svelte
@langchain/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2656
Invoking a graph that fans out with
SendundermaxConcurrency: 1silently skips every task after the first. No error is raised and the output is structurally valid, so the lost work leaves no signal downstream.Root cause
The scheduling loop in
PregelRunner._executeTasksWithRetrycontinues while:With a limit of 1,
executingTasksMapholds a single task. When it settles and is deleted at the bottom of the loop, the map is empty andstartedTasksCountis non-zero, so the loop exits with the remaining tasks never scheduled. Any limit >= 2 keeps at least one task in flight across a settle, which is why only1is affected.The condition conflates "nothing in flight" with "nothing left to start".
Fix
Continue while unstarted tasks remain or tasks are in flight. The inner top-up loop already caps in-flight work at
maxConcurrency, so the limit itself is unchanged. Tasks injected mid-tick (error handlers, PUSH tasks viacall) still keep the loop alive through the barrier exactly as before.Reproduction from the issue:
Test
Regression test added beside the existing
test_max_concurrencyport: a 6-waySendfan-out atmaxConcurrency: 1must complete all six tasks and observe a peak concurrency of exactly 1 — so a future change can't "fix" this by quietly widening the limit. Fails onmain(0 of 6 tasks run), passes with this change.libs/langgraph-core: 79 files, 1639 tests passed, 0 type errors.oxlintandoxfmt --checkclean.