chore: fix clippy lints from newer toolchains - #62
Merged
Conversation
…ecessary_sort_by) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mise run verifyfails on local toolchains newer than the pinned 1.90.0 (e.g. mise's cargo 1.93) because recent clippy versions promoted new cases ofcollapsible_matchandunnecessary_sort_by, and verify runs clippy with-D warnings. These 10 findings are pre-existing onmainand unrelated to any recent change.What
All fixes are mechanical and behavior-preserving:
matcharms containing a loneifinto guarded arms (watch_tui.rs,engine/export.rs,codex/io.rs). The non-matching cases fall through to the existing_ => {}arms, so behavior is identical.sort_by(|a, b| ...cmp...)assort_by_key, usingstd::cmp::Reversefor the descending sorts (runtime/streamer.rs,storage/repository.rs,presenters/project.rs, 3 SDK examples).sort_by_keyis also a stable sort, so same-timestamp event ordering is preserved.agtrace-coresuggested by clippy.Verification
mise run verify(fmt + clippy-D warnings+ test + build) now passes locally on cargo 1.93; clippy warning count is 0 across the workspace including--all-targets.🤖 Generated with Claude Code