fix(cli): emit single JSON document from session show with sidechains - #61
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
agtrace session show <id> --format jsonproduced invalid JSON when the session contained sidechains (subagent streams). Each stream was rendered as a separate JSON document, with text separators printed between them:Root cause:
handlers/session_show.rslooped over streams callingctx.render()once per stream andprintln!-ing separators unconditionally — bypassing the format abstraction entirely.Fix (schema-level redesign)
One
session showinvocation now produces exactly one view model → one document, in every format:SessionDetailViewModel { session, streams[] }replaces the per-streamSessionAnalysisViewModel/SessionHeader. Session-scoped metadata (id, provider, project, log files) appears once; each stream carries its ownstream_id,spawned_by(raw 0-based indices),status,context_summary, andturns.present_session_detail) takes all assembled streams, orders them Main-first, and attaches subagent children to the main stream.SessionDetailView) owns the text-mode stream separators/headings that the handler previously printed — the handler no longer prints anything itself.agtrace-sdknow re-exportsSpawnContextso the CLI can consume it through the SDK boundary.Verification
content.streams[4], each sidechain carrying structuredspawned_by. Text mode still renders per-stream sections with separators.cargo test: all pass. Clippy is clean on 1.90.0 (the 6 pre-existing warnings visible on newer local toolchains also exist on main).🤖 Generated with Claude Code