fix(claude): surface redacted thinking and reasoning tokens - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First code fix from the v2.1 log-format audit (#57). Addresses the original symptom — thinking became invisible — plus reasoning-token accounting.
Adaptive thinking (Opus 4.7+) no longer persists plaintext thinking: blocks arrive as
{"type":"thinking","thinking":"","signature":"…"}. The text is unrecoverable, so:thinkingwith asignaturenow emits aReasoningevent with[thinking redacted]instead of a blank line. Blocks with neither text nor signature are dropped.usage.output_tokens_details.thinking_tokensinto the reasoning bucket (previously hardcoded to0). Sinceoutput_tokensalready includes thinking,generated = output_tokens - reasoning, keepingtotal()unchanged. Pre-v2.1 logs lack the field, so they behave exactly as before.Changes
claude/schema.rs: addOutputTokensDetail { thinking_tokens }toTokenUsage.claude/parser.rs: redacted-thinking marker; reasoning-token split; 3 new unit tests.output_tokens_details: nullin raw output; no event-level change).Notes
systemsubtypes are handled in a follow-up PR.🤖 Generated with Claude Code